-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accept multiple SSH keys in single LDAP SSHPublicKey attribute #13989
Accept multiple SSH keys in single LDAP SSHPublicKey attribute #13989
Conversation
Fix go-gitea#13984 Signed-off-by: Andrew Thornton <art27@cantab.net>
Thanks, I'll try to test this out, but I'm blocked by #13993 at the moment. |
tests fail now |
UGh this is quite a bit more fiddly than I initially expected. |
Turns out that the last problem was that the marshall authorized key added a newline - which was the cause of the failing test! |
Signed-off-by: Andrew Thornton <art27@cantab.net>
Codecov Report
@@ Coverage Diff @@
## master #13989 +/- ##
==========================================
- Coverage 42.23% 42.13% -0.10%
==========================================
Files 710 710
Lines 77261 77291 +30
==========================================
- Hits 32629 32570 -59
- Misses 39266 39370 +104
+ Partials 5366 5351 -15
Continue to review full report at Codecov.
|
Great that you handled to fix the existing tests, but would you please consider adding a new test for having multiple keys and malicious code in single elements coming from LDAP ? That was the issue reported in #13984 |
Signed-off-by: Andrew Thornton <art27@cantab.net>
Great work ! LGTM |
…tea#13989) Backport go-gitea#13989 Fix go-gitea#13984 Fix go-gitea#14566 Signed-off-by: Andrew Thornton <art27@cantab.net>
Fix #13984
Signed-off-by: Andrew Thornton art27@cantab.net